Skip to content

Conversation

@schloerke
Copy link
Collaborator

@schloerke schloerke commented Oct 7, 2024

Errors being seen in #1721 (and other PRs)

-------- Checking types with pyright --------
pyright
/home/runner/work/py-shiny/py-shiny/tests/playwright/shiny/components/data_frame/edit/app.py
  /home/runner/work/py-shiny/py-shiny/tests/playwright/shiny/components/data_frame/edit/app.py:92:30 - error: Condition will always evaluate to False since the types "Loc" and "Literal['data']" have no overlap (reportUnnecessaryComparison)
/home/runner/work/py-shiny/py-shiny/tests/playwright/shiny/components/data_frame/styles/great_tables_test_utils.py
  /home/runner/work/py-shiny/py-shiny/tests/playwright/shiny/components/data_frame/styles/great_tables_test_utils.py:26:30 - error: Condition will always evaluate to False since the types "Loc" and "Literal['data']" have no overlap (reportUnnecessaryComparison)
  /home/runner/work/py-shiny/py-shiny/tests/playwright/shiny/components/data_frame/styles/great_tables_test_utils.py:42:29 - error: Argument of type "dict[str, Loc | str | int | dict[str, Jsonifiable]]" cannot be assigned to parameter "object" of type "StyleInfo" in function "append"
    Type "Loc | Literal['body']" is incompatible with type "Literal['body']"
      "Loc" is incompatible with type "Literal['body']" (reportArgumentType)
3 errors, 0 warnings, 0 informations 
WARNING: there is a new pyright version available (v1.1.369 -> v1.1.383).
Please install the new version or set PYRIGHT_PYTHON_FORCE_VERSION to `latest`

@schloerke schloerke merged commit 5a0ec92 into main Oct 7, 2024
40 checks passed
@schloerke schloerke deleted the chore-unlock-pyright branch October 7, 2024 16:18
schloerke added a commit that referenced this pull request Oct 7, 2024
* main:
  chore(docs): Update dev install instructions (#1721)
  chore(pyright): Unlock pyright version with minimum at `1.1.383` (#1722)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant